Repository navigation
Conversation
weanty0
marked this pull request as draft
November 18, 2026 07:47
weanty0
marked this pull request as ready for review
November 18, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #284
(read the issue for all of da details)
Checking if FreeBSD is defined before defining
_POSIX_C_SOURCEand skipping definition if yes, does not turn__BSD_VISIBLEoff. This smol fix ensures that_SC_NPROCESSORS_ONLNis still defined in<unistd.h>.Another possible fix:
Keep the
_POSIX_C_SOURCEdefine everywhere and usesysctlon bsds that hide_SC_NPROCESSORS_ONLN(FreeBSD, NetBSD, DragonFly):, this needs
<sys/param.h>and<sys/sysctl.h>defined on netbsd and dragonfly.